-
Notifications
You must be signed in to change notification settings - Fork 1k
Markdown toc for style guide #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we please keep the Plus, if we ever want to post a version of the site for people to comment on ever again (like I did here: http://lampwww.epfl.ch/~hmiller/new-docsite) we need the absolute paths so the site can be placed in a subdirectory and for links to still work. (Not having |
Ah, ok, that's good to know. I noticed a lot of the site was using relative linking, so I assumed it was ok. I'm surprised Jekyll doesn't DTRT with links in markdown here by inserting |
Yeah, it's a super confusing situation. In the _data files (.yml), we can't use site variables, so we've got to use relative linking, which usually works (but not always). So that's where you might be seeing a bunch of relative links when you look around. Anywhere else though, such as in markdown files or CSS/JS (with empty I actually looked around for a link analyzing plugin for Jekyll to insert the stupid |
I'm so confused. I'm looking at the links on this page http://lampwww.epfl.ch/~hmiller/new-docsite/tour/tour-of-scala.html When I click on the first link, I got to http://lampwww.epfl.ch/~hmiller/new-docsite/unified-types.html That's totally broken. I can confirm that. The <a href="unified-types.html">every value is an object</a> Is there some Javascript on the site interacting with links? When I disable Javascript, the link works. What??? |
Yeah, on that site there's JavaScript fixing relative linking problems. ...In that case, the JavaScript broke things more than it fixed them. Though most other links wouldn't work w/out the JS futzing. |
Ah, ok. That makes me feel a little more sane. So, without the JS futzing, won't the links on this page work fine then? |
Yep, they should. (This is one case where relative linking actually works 🙄) |
Merci! ❤️ |
Doesn't look like there was a reason for the table of contents to be in HTML, so simplify? It renders the same.